Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card: Add a shortcode to better generate example page #1827

Merged
merged 6 commits into from
Feb 20, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Feb 9, 2023

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Fixes #1693.

Description

Add a shortcode to replace each card.

Awaiting reply: Should the shortcode stay like that (generate one card) or should it generate a line directly (less options so maybe easier to maintain/understand) ? -> Should stay like that because we may have some more example to introduce here.

Motivation & Context

Resolve some issues on SonarCloud and make it more easy to change

Types of change

  • Refactoring (non-breaking change)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • (NA) My change introduces changes to the migration guide
  • (NA) My new component is added in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@netlify
Copy link

netlify bot commented Feb 9, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 6729603
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63f37b20be14d90008f1937a
😎 Deploy Preview https://deploy-preview-1827--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@louismaximepiton louismaximepiton changed the title Card Card: Add a shortcode to better generate example page Feb 9, 2023
@louismaximepiton louismaximepiton marked this pull request as ready for review February 9, 2023 10:35
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't checked in detail. The rendering is the same as before; not exactly since it fixes an issue regarding text color due to the color mode.
Few details to improve and we're good to go 🚀

site/layouts/shortcodes/card.html Outdated Show resolved Hide resolved
site/layouts/shortcodes/card.html Outdated Show resolved Hide resolved
site/layouts/shortcodes/card.html Outdated Show resolved Hide resolved
site/layouts/shortcodes/card.html Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit 99cd4f1 into main Feb 20, 2023
@julien-deramond julien-deramond deleted the main-lmp-shortcode-for-card-example branch February 20, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance cards creation in cards examples
2 participants