Chore merge from d70b5db to 803d9d4 #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
force-pushed
the
main-jd-chore-merge-from-da1c968
branch
from
8c10da3
to
dbcfafb
Compare
julien-deramond
force-pushed
the
main-jd-chore-merge-from-d70b5db
branch
from
a8890a6
to
a90dbcc
Compare
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
julien-deramond
force-pushed
the
main-jd-chore-merge-from-d70b5db
branch
from
006ac45
to
acbd92a
Compare
|
Haven't checked everything in detail, but this first draft seems OK. |
julien-deramond
changed the title
27 tasks
louismaximepiton
requested changes
Feb 23, 2023
| 75: .75, | ||
| 100: 1 | ||
| ), | ||
| ), |
There was a problem hiding this comment.
[Bootstrap Side] Shouldn't we add some 0 values in here ? Or maybe add state: hover for text-decoration ? Might be Boosted side only to have links not underlined and underlined on hover ?
julien-deramond
commented
Feb 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR "only" integrates twbs/bootstrap@d70b5db and twbs/bootstrap@803d9d4 to facilitate the review by isolating this new helper.
(integrated the second one to quickly fix the issue with the titles' color in the docs :p)
Live previews
TODO