Shortcode: Adding the picture icon on placeholder when text to display is "false"

[louismaximepiton]

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#1839

Description

Add an icon on placeholder shortcode.

Motivation & Context

Be closer to the design specs

Types of change

• New feature (non-breaking change which adds functionality)

Live previews

• https://deploy-preview-1857--boosted.netlify.app/docs/components/placeholders#example

Checklist

Contribution

• I have read the contributing guidelines

Accessibility

• My change follows accessibility good practices; I have at least run axe

Design

• My change respects the design guidelines defined in Orange Design System
• My change is compatible with responsive display

Development

• My change follows the developer guide
• (NA) I have added JavaScript unit tests to cover my changes
• (NA) I have added SCSS unit tests to cover my changes

Documentation

• My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

• (NA) My change introduces changes to the migration guide
• (NA) My new component is added in Storybook
• (NA) My new component is compatible with RTL
• Manually run BrowserStack tests
• Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
• Code review
• Design review
• A11y review

After the merge

• Manually launch Percy tests

[netlify]

✅ Deploy Preview for boosted ready!

Name	Link
🔨 Latest commit	5287c96
🔍 Latest deploy log	https://app.netlify.com/sites/boosted/deploys/63fc5c392ced3b0008a43b11
😎 Deploy Preview	https://deploy-preview-1857--boosted.netlify.app/docs/5.3/components/placeholders
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[julien-deramond]

Not a big fan of using text to display the icons but this shortcode is already very complex so let's handle it like this for now.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication