Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore merge from 436de31 #1872

Merged
merged 24 commits into from
Mar 7, 2023
Merged

Conversation

julien-deramond
Copy link
Contributor

@julien-deramond julien-deramond commented Mar 6, 2023

@julien-deramond julien-deramond added v5 merge Sync with Bootstrap labels Mar 6, 2023
@julien-deramond julien-deramond changed the base branch from main to main-jd-chore-merge-from-17f14ac March 6, 2023 07:57
@netlify
Copy link

netlify bot commented Mar 6, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit fab7438
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6406edd46dca1f0009be666c
😎 Deploy Preview https://deploy-preview-1872--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Base automatically changed from main-jd-chore-merge-from-17f14ac to main March 6, 2023 08:44
@julien-deramond julien-deramond force-pushed the main-jd-chore-merge-from-436de31 branch from 751081c to 13fd01f Compare March 6, 2023 08:45
@julien-deramond julien-deramond marked this pull request as ready for review March 6, 2023 11:36
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sass variables inside buttons.md doesn't have the right title level on our side.
Some few changes but looks already good (even dark mode)!

site/content/docs/5.3/utilities/colors.md Show resolved Hide resolved
site/layouts/shortcodes/scss-docs.html Show resolved Hide resolved
site/content/docs/5.3/migration.md Show resolved Hide resolved
site/content/docs/5.3/customize/color.md Outdated Show resolved Hide resolved
@julien-deramond
Copy link
Contributor Author

Sass variables inside buttons.md doesn't have the right title level on our side.

Good catch. Fixed in 6e6df26

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit bed880e into main Mar 7, 2023
@julien-deramond julien-deramond deleted the main-jd-chore-merge-from-436de31 branch March 7, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Sync with Bootstrap v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants