Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase 1px margin for form messages to conform to design #1948

Merged
merged 6 commits into from
Jul 3, 2023

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Apr 4, 2023

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Linked to issues #1761 and #1767.
Based on the discussions that happened in #1779 (direct link).

Description

During the changes made on form texts to conform to new UI kit V5, it has been seen that the margin between form inputs and messages (both form texts and validation messages) was lacking 1px.

Motivation & Context

This change is required to have the exact same height between the bottom of the input field and the top of the uppercase letters at 10px, both in Boosted and in designs.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is added in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit bbcbce0
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/64a2ab124cefe6000897e4d0
😎 Deploy Preview https://deploy-preview-1948--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hannahiss hannahiss marked this pull request as ready for review May 2, 2023 13:39
@louismaximepiton louismaximepiton self-requested a review June 5, 2023 14:44
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Franco-Riccitelli
Copy link

All looks good. No issues.

@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond self-requested a review July 3, 2023 11:10
@julien-deramond julien-deramond merged commit 6737e8e into main Jul 3, 2023
@julien-deramond julien-deramond deleted the main-his-form-msg-vmargin branch July 3, 2023 11:12
@julien-deramond julien-deramond mentioned this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants