-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom popover padding #2031
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as resolved.
This comment was marked as resolved.
After PR review by @isabellechanclou , it appears that Note: Should we add a design callout to warn people that any customisation means that the component is no longer compatible with the DSM? |
LGTM ! |
LGTM ! |
I just added to this PR the prototype made by @julien-deramond in PR #2077 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes but looks fine already
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Related issues
Closes #1937
Description
Fix padding for custom popover while keeping new design unchanged.
Motivation & Context
Design broken after design update:
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge