Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a11y problems on star rating component #2035
Fix a11y problems on star rating component #2035
Changes from all commits
ac3b095
1382ce2
d0a53bc
cfc26f4
5497de9
b798952
3d4d655
bd9eae2
908d74b
7370011
2b66a8c
1f66fec
c8a7f43
f892ea1
58e1db0
43bc461
9b160ad
00862dc
4c17a5d
37b4f48
a8153b5
162c728
1e6f619
622fb8a
45abcc9
5b31c2b
2b9aad1
ef47e71
9351ae3
24f625b
6b3d845
172e9c3
775337b
3385cd5
42a6ac1
796f3f7
683e4e2
e253bb6
ed54f89
a69c126
707033c
a25657d
f15d864
3960fb4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels weird to have it here since it's not the same behavior and not the same purpose. Do you think we should have a proper section for this component (I mean the whole star rating) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be a good thing yes since we now have normal/small versions + light/dark versions + disabled state + readonly state etc. It's probably too much for a simple section in the
Checks & radios
page.In addition the
disabled
state is supposed to be used outside of a form, in a card for instance, so there is no reason to keep it in theForms
section although the rest of the star rating thing is still a form element. 🤔Should we split it? (🤢)