Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borders: add design callout messages #2064

Merged
merged 13 commits into from
Aug 30, 2023

Conversation

isabellechanclou
Copy link
Member

@isabellechanclou isabellechanclou commented Jun 5, 2023

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes #2062
Closes #2063

Description

After a design review of all the card variants, the purpose of this PR is to fix the design of some variants in order to make them aligned on the Orange design specifications and to add design callout messages before the variants that should not be used because not suitable in Orange design system.

Motivation & Context

The goal here is to offer in Boosted more guidance on what can be used or not in Orange apps and to reduce discrepancies between Boosted documentation and the Orange design system one.

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • (NA) Refactoring (non-breaking change)
  • (NA) Breaking change (fix or feature that would change existing functionality)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes
  • (NA) I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • (NA) My change introduces changes to the migration guide
  • (NA) My new component is added in Storybook
  • (NA) My new component is compatible with RTL
  • (NA) Manually run BrowserStack tests
  • (NA) Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • (NA) Design review
  • (NA) A11y review

After the merge

Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
@isabellechanclou isabellechanclou added v5 component docs Improvements or additions to documentation enhancement labels Jun 5, 2023
@isabellechanclou isabellechanclou self-assigned this Jun 5, 2023
@netlify
Copy link

netlify bot commented Jun 5, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 40082dd
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/64ef25a1fad57d0008e728cc
😎 Deploy Preview https://deploy-preview-2064--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond marked this pull request as draft June 5, 2023 10:19
@isabellechanclou isabellechanclou marked this pull request as ready for review June 5, 2023 12:54
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not really convinced of the side effects these callouts could bring. However, here are my concerns

site/content/docs/5.3/utilities/borders.md Outdated Show resolved Hide resolved
site/content/docs/5.3/utilities/borders.md Outdated Show resolved Hide resolved
@isabellechanclou isabellechanclou changed the title Borders: add design callouts messages Borders: add design callout messages Jun 6, 2023
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some proposals for the wording. Tell me what you think, and I'll finalize + merge the PR based on your latest feedback.

site/content/docs/5.3/utilities/borders.md Outdated Show resolved Hide resolved
site/content/docs/5.3/utilities/borders.md Outdated Show resolved Hide resolved
site/content/docs/5.3/utilities/borders.md Outdated Show resolved Hide resolved
site/content/docs/5.3/utilities/borders.md Outdated Show resolved Hide resolved
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@julien-deramond julien-deramond merged commit 7ab472c into main Aug 30, 2023
12 checks passed
@julien-deramond julien-deramond deleted the main-ic-add-design-callouts-in-borders branch August 30, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation enhancement v5
Projects
Development

Successfully merging this pull request may close these issues.

Borders : fix design Borders : add design callout messages
3 participants