-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Borders: add design callout messages #2064
Borders: add design callout messages #2064
Conversation
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not really convinced of the side effects these callouts could bring. However, here are my concerns
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some proposals for the wording. Tell me what you think, and I'll finalize + merge the PR based on your latest feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
Closes #2062
Closes #2063Description
After a design review of all the card variants, the purpose of this PR is to fix the design of some variants in order to make them aligned on the Orange design specifications and to add design callout messages before the variants that should not be used because not suitable in Orange design system.
Motivation & Context
The goal here is to offer in Boosted more guidance on what can be used or not in Orange apps and to reduce discrepancies between Boosted documentation and the Orange design system one.
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge