New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stickers example: fix id #2066

Merged

julien-deramond merged 1 commit into main from main-lmp-stickers-example-fix

Jun 6, 2023

Member

louismaximepiton commented Jun 5, 2023 •

edited by boosted-bot

Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

NA

Description

Set the correct id on stickers svg

Motivation & Context

NA

Types of change

Bug fix (non-breaking which fixes an issue)

Live previews

https://deploy-preview-2066--boosted.netlify.app/docs/examples/stickers

Checklist

Contribution

I have read the contributing guidelines

Accessibility

My change follows accessibility good practices; I have at least run axe

Design

My change respects the design guidelines defined in Orange Design System
My change is compatible with responsive display

Development

My change follows the developer guide
(NA) I have added JavaScript unit tests to cover my changes
(NA) I have added SCSS unit tests to cover my changes

Documentation

(NA) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

(NA) My change introduces changes to the migration guide
(NA) My new component is added in Storybook
(NA) My new component is compatible with RTL
Manually run BrowserStack tests
Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
Code review
Design review
A11y review

After the merge

Manually launch Percy tests

Fix

588b59f

louismaximepiton added v5 examples fix labels

louismaximepiton self-assigned this

netlify bot commented Jun 5, 2023

✅ Deploy Preview for boosted ready!

Name	Link
🔨 Latest commit	`588b59f`
🔍 Latest deploy log	https://app.netlify.com/sites/boosted/deploys/647de649365844000889170c
😎 Deploy Preview	https://deploy-preview-2066--boosted.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sonarcloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

julien-deramond approved these changes

View reviewed changes

Member

julien-deramond left a comment

Hooo good catch

julien-deramond merged commit f7727f5 into main

julien-deramond deleted the main-lmp-stickers-example-fix branch

June 6, 2023 06:40

julien-deramond mentioned this pull request

v5.3.0 Ship List #1762

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment