Docs: fix search box alignment in navbar

[hannahiss]

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

• Change .nav-item class to .navbar-item
• Move todo outside of visible code example

Motivation & Context

Changes needed:

• to have the right alignment of search box in navbar (it was ok in the example, but not ok in displayed code)
• not to have a visible todo

Types of change

• Bug fix (non-breaking which fixes an issue)

Live previews

• https://deploy-preview-2078--boosted.netlify.app/docs/5.3/components/orange-navbar#with-search-box

Checklist

Contribution

• I have read the contributing guidelines

Accessibility

• My change follows accessibility good practices; I have at least run axe

Design

• My change respects the design guidelines defined in Orange Design System
• My change is compatible with responsive display

Development

• My change follows the developer guide
• (NA) I have added JavaScript unit tests to cover my changes
• (NA) I have added SCSS unit tests to cover my changes

Documentation

• My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

• My change introduces changes to the migration guide
• (NA) My new component is added in Storybook
• (NA) My new component is compatible with RTL
• (NA) Manually run BrowserStack tests
• (NA) Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
• Code review
• Design review
• A11y review

After the merge

• Manually launch Percy tests

[netlify]

✅ Deploy Preview for boosted ready!

Name	Link
🔨 Latest commit	ba99574
🔍 Latest deploy log	https://app.netlify.com/sites/boosted/deploys/6486c78d9751f900086e25db
😎 Deploy Preview	https://deploy-preview-2078--boosted.netlify.app/docs/5.3/components/orange-navbar
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[julien-deramond]

Dropped entirely the useless TODO via 254442c.

There's probably a missing .col-3 class as well (suggestion in the code).

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information