SCSS: remove $boosted-prefix in favor of $prefix
#2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
louismaximepiton
commented
Jul 5, 2023
| @@ -86,7 +86,7 @@ | |||
|
|
|||
| .carousel-control-prev, | |||
| .carousel-control-next { | |||
| --#{$boosted-prefix}control-bg: #{rgba($carousel-indicator-active-bg, .5)}; // Boosted mod | |||
| --#{$prefix}control-bg: #{rgba($carousel-indicator-active-bg, .5)}; // Boosted mod | |||
There was a problem hiding this comment.
Suggested change
| --#{$prefix}control-bg: #{rgba($carousel-indicator-active-bg, .5)}; // Boosted mod | |
| --#{$prefix}carousel-control-bg: #{rgba($carousel-indicator-active-bg, .5)}; // Boosted mod |
| @@ -141,7 +141,7 @@ | |||
| --#{$prefix}alert-icon-size: #{$alert-icon-size-sm}; | |||
| --#{$prefix}alert-btn-close-offset: #{$alert-btn-close-offset-sm}; | |||
| // scss-docs-end alert-sm-css-vars | |||
| --#{$boosted-prefix}icon-spacing: #{$btn-close-padding-sm}; | |||
| --#{$prefix}icon-spacing: #{$btn-close-padding-sm}; | |||
There was a problem hiding this comment.
Suggested change
| --#{$prefix}icon-spacing: #{$btn-close-padding-sm}; | |
| --#{$prefix}btn-icon-spacing: #{$btn-close-padding-sm}; |
|
Made some changes in b283fd5. @louismaximepiton I let you double-check that they were expected. |
julien-deramond
requested changes
Jul 11, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
Closes #1553.
Description
Change all
$boosted-prefixin favor of$prefixto harmonize our framework.Might be merged for v6 only maybe ?
Motivation & Context
End user will only have one prefix and not being forced to switch beside two of them.
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge