Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Add download app example #2146

Merged
merged 62 commits into from
Jul 19, 2023
Merged

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jul 18, 2023

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Superseed #1915.

Description

Remove all reference to tac since there is no cookie from mastermedia.

Motivation & Context

NA

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is added in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit b2effe8
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/64b79d5ddcd5a100080903a3
😎 Deploy Preview https://deploy-preview-2146--boosted.netlify.app/docs/5.3/migration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton changed the title Main lmp download app Examples: Add download app example Jul 18, 2023
@julien-deramond

This comment was marked as resolved.

Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
@julien-deramond
Copy link
Member

julien-deramond commented Jul 19, 2023

Not to tackle in this PR because we do that at other places too, but Firefox is complaining about the fact that we use rem to define SVG width and height, and it's right apparently. Maybe we should create an issue to check that.

Unexpected value 6.25rem parsing height attribute.
Unexpected value 3.75rem parsing width attribute.
[... a lot of warning messages]
Unexpected value 1.25rem parsing height attribute.

@julien-deramond
Copy link
Member

There are 3 style="..." in the HTML that should be moved to the CSS file if possible.

@julien-deramond julien-deramond self-requested a review July 19, 2023 08:19
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@julien-deramond julien-deramond merged commit e08aaaa into main Jul 19, 2023
15 checks passed
@julien-deramond julien-deramond deleted the main-lmp-download-app branch July 19, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants