Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a11y audit bug: alt attribute of an image containing text #2692

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions site/content/docs/5.3/getting-started/parcel.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ With dependencies installed and our project folder ready for us to start coding,
npm start
```

![Parcel dev server running](/assets/img/guides/parcel-dev-server.png)
![Unbranded web page displaying a title 'Hello, Boosted and Parcel!' and a default button](/assets/img/guides/parcel-dev-server.png)

In the next and final section to this guide, we'll import all of Boosted's CSS and JavaScript.

Expand Down Expand Up @@ -169,7 +169,7 @@ Importing Boosted into Parcel requires three imports, two into our `styles.scss`

4. **And you're done! 🎉** With Boosted's source Sass and JS fully loaded, your local development server should now look like this:

![Parcel dev server running with Boosted](/assets/img/guides/parcel-dev-server-boosted.png)
![Boosted branded web page displaying a title 'Hello, Boosted and Parcel!' and an orange primary button](/assets/img/guides/parcel-dev-server-boosted.png)

Now you can start adding any Boosted components you want to use. Be sure to [check out the complete Parcel example project](https://github.com/twbs/examples/tree/main/parcel) for how to include additional custom Sass and optimize your build by importing only the parts of Boosted's CSS and JS that you need.

Expand Down
4 changes: 2 additions & 2 deletions site/content/docs/5.3/getting-started/vite.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ With dependencies installed and our project folder ready for us to start coding,
npm start
```

![Vite dev server running](/assets/img/guides/vite-dev-server.png)
![Unbranded web page displaying a title 'Hello, Boosted and Vite!' and a default button](/assets/img/guides/vite-dev-server.png)

In the next and final section to this guide, we’ll import all of Boosted’s CSS and JavaScript.

Expand Down Expand Up @@ -191,7 +191,7 @@ In the next and final section to this guide, we’ll import all of Boosted’s C

4. **And you're done! 🎉** With Boosted's source Sass and JS fully loaded, your local development server should now look like this:

![Vite dev server running with Boosted](/assets/img/guides/vite-dev-server-boosted.png)
![Boosted branded web page displaying a title 'Hello, Boosted and Vite!' and an orange primary button](/assets/img/guides/vite-dev-server-boosted.png)

Now you can start adding any Boosted components you want to use. Be sure to [check out the complete Vite example project](https://github.com/twbs/examples/tree/main/vite) for how to include additional custom Sass and optimize your build by importing only the parts of Boosted's CSS and JS that you need.

Expand Down
10 changes: 5 additions & 5 deletions site/content/docs/5.3/getting-started/webpack.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ With dependencies installed and our project folder ready for us to start coding,
npm start
```

![Webpack dev server running](/assets/img/guides/webpack-dev-server.png)
![Unbranded web page displaying a title 'Hello, Boosted and Webpack!' and a default button](/assets/img/guides/webpack-dev-server.png)

In the next and final section to this guide, we'll set up the Webpack loaders and import all of Boosted's CSS and JavaScript.

Expand Down Expand Up @@ -263,11 +263,11 @@ Importing Boosted into Webpack requires the loaders we installed in the first se

*[Read our JavaScript docs]({{< docsref "/getting-started/javascript/" >}}) for more information on how to use Boosted's plugins.*

4. **And you're done! 🎉** With Boosted's source Sass and JS fully loaded, your local development server should now look like this:
4. **And you're done! 🎉** With Boosted's source Sass and JS fully loaded, your local development server should now look like this:

![Webpack dev server running with Boosted](/assets/img/guides/webpack-dev-server-boosted.png)
![Boosted branded web page displaying a title 'Hello, Boosted and Webpack!' and an orange primary button](/assets/img/guides/webpack-dev-server-boosted.png)

Now you can start adding any Boosted components you want to use. Be sure to [check out the complete Webpack example project](https://github.com/twbs/examples/tree/main/webpack) for how to include additional custom Sass and optimize your build by importing only the parts of Boosted's CSS and JS that you need.
Now you can start adding any Boosted components you want to use. Be sure to [check out the complete Webpack example project](https://github.com/twbs/examples/tree/main/webpack) for how to include additional custom Sass and optimize your build by importing only the parts of Boosted's CSS and JS that you need.

## Production optimizations

Expand Down Expand Up @@ -295,7 +295,7 @@ Then instantiate and use the plugin in the Webpack configuration:
const autoprefixer = require('autoprefixer')
const HtmlWebpackPlugin = require('html-webpack-plugin')
+const miniCssExtractPlugin = require('mini-css-extract-plugin')

module.exports = {
mode: 'development',
@@ -17,7 +18,8 @@ module.exports = {
Expand Down
Loading