Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OUDS] Add border color utilities to the Colors tokens PR #2823

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Dec 17, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

NA

Description

Remaining tasks and questions

⚠️ Questions:

  • What is the correspondence between Bootstrap border color utilities and ours ?
  • What is the complete list of border color utilities that we should provide ?
  • How much do we want to spend and be precised on the documentation ?

Tasks:

Done list

The following was done in the PR:

  • Added new border color utilities
  • Added paragraph about the colors inside borders page
  • Changed all the .border-* calls in the doc
  • Changed all the border(|color): calls in the not components

To be done after the PR is merged

Motivation & Context

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

@louismaximepiton louismaximepiton added docs Improvements or additions to documentation css labels Dec 17, 2024
@louismaximepiton louismaximepiton added this to the OUDS milestone Dec 17, 2024
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-border-utilities branch 2 times, most recently from 797713a to 31097e6 Compare December 23, 2024 10:26
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-bg-utilities branch from 9db1ce9 to 29f453f Compare December 26, 2024 10:18
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-border-utilities branch 2 times, most recently from 4a11a41 to 2617225 Compare December 27, 2024 09:23
scss/_maps.scss Outdated Show resolved Hide resolved
site/content/docs/0.0/utilities/position.md Outdated Show resolved Hide resolved
site/content/docs/0.0/utilities/borders.md Outdated Show resolved Hide resolved
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-border-utilities branch from 2617225 to 10b3d2a Compare December 27, 2024 11:32
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-border-utilities branch from 10b3d2a to 741f161 Compare December 30, 2024 08:31
Base automatically changed from ouds/main-lmp-tokens-colors-bg-utilities to ouds/main-lmp-tokens-colors January 6, 2025 10:19
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-border-utilities branch from 741f161 to fa59b11 Compare January 6, 2025 15:53
Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit fa59b11
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/677bfc62eb2cf20008d8e628
😎 Deploy Preview https://deploy-preview-2823--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vprothais vprothais merged commit 40a0bce into ouds/main-lmp-tokens-colors Jan 8, 2025
12 checks passed
@vprothais vprothais deleted the ouds/main-lmp-tokens-colors-border-utilities branch January 8, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css docs Improvements or additions to documentation
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants