fix(pa11y): hide contrast issue from badge positioning #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second commit comes from tests done in #741 (that I closed). If the automatic tests are green in this PR, it can be merged. |
julien-deramond
force-pushed
the
hide-760-issue
branch
from
63c02a4 to
9f5ca6f
Compare
This was referenced Aug 25, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pa11y CI job still fails but this PR still fixes the issue about the contrast in badge positioning.
In order to review this PR, you can test to set the concurrency to 1 in
build/.pa11yci.jsoninv5-devand compare the results to this version.