Move to manifest V3 #104
Merged
Move to manifest V3 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffoodd
force-pushed
the
chore/manifest-v3
branch
from
efa6e9b to
c9a31ca
Compare
This comment was marked as outdated.
This comment was marked as outdated.
12 tasks
ffoodd
force-pushed
the
chore/manifest-v3
branch
from
8bf43b5 to
b395290
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ffoodd
force-pushed
the
chore/manifest-v3
branch
from
4c6e45e to
81c70b8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Lausselloic
reviewed
Mar 15, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Jun 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used
addons-linterto help a bit, available locally withnpm run lint:ext. FWIW Mozilla's Web Extension polyfill is probably useless with Manifest V3.Changes
localStoragecannot be accessed anymore, need to usechrome.storage.local()and ask for thestoragepermission,browser_actionin manifest file andbrowserActionAPI are removed: switched toactionon both sides.chrome.extension.getURL()is replaced withchrome.runtime.getURL()Had tons of work moving everything to the new Promise-based APIs.
Current status
manifest.json, see below.@Lausselloic I added quite a few npm scripts: we might want to lighten
package.jsona bit by moving scripts in abuild/folder, as done to inline.woff2files or in Boosted. Would be more verbose but probably more readable, too.