Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure --connect-timeout per request #3163

Closed
jcamiel opened this issue Aug 20, 2024 · 2 comments · Fixed by #3306
Closed

Configure --connect-timeout per request #3163

jcamiel opened this issue Aug 20, 2024 · 2 comments · Fixed by #3306
Labels
enhancement New feature or request open-to-contribution Open to external contributers
Milestone
6.0.0

Comments

@jcamiel
Copy link
Collaborator

jcamiel commented Aug 20, 2024

Make --connect-timeout configurable per request:

GET https://foo.bin
[Options]
connect-timeout: 500s
HTTP 200

Note: there is a bug in the man page where connect-timeoutis not marked as cli-only
@jcamiel jcamiel added enhancement New feature or request open-to-contribution Open to external contributers labels Aug 20, 2024
@aarcex3
Copy link

aarcex3 commented Sep 28, 2024

Hi, I would like to work in this. I'm not very familiar with rust but still wanna give it a try.
Where should I look in the project?
Thanks.

@fabricereix
Copy link
Collaborator

Hi @aarcex3,
you can have a look how another option was implemented such as #2288
make sure also to read https://github.com/Orange-OpenSource/hurl/blob/master/CONTRIBUTING.md

zikani03 added a commit to zikani03/hurl that referenced this issue Oct 14, 2024
@zikani03
feat: add connect-timeout option per request
59036a9 
Added a connect-timeout option to allow users to specify a
connect-timeout for each request in a hurl file.

Closes Orange-OpenSource#3163
@zikani03 zikani03 mentioned this issue Oct 14, 2024
Merged
zikani03 added a commit to zikani03/hurl that referenced this issue Oct 14, 2024
@zikani03
feat: add connect-timeout option per request
cbbf1ae 
Added a connect-timeout option to allow users to specify a
connect-timeout for each request in a hurl file.

Closes Orange-OpenSource#3163
hurl-bot pushed a commit to zikani03/hurl that referenced this issue Oct 15, 2024
@zikani03 @hurl-bot
feat: add connect-timeout option per request
a3e9b1a 
Added a connect-timeout option to allow users to specify a
connect-timeout for each request in a hurl file.

Closes Orange-OpenSource#3163
@jcamiel jcamiel added this to the 6.0.0 milestone Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request open-to-contribution Open to external contributers
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Configure --connect-timeout per request zikani03/hurl
3 participants
@fabricereix @jcamiel @aarcex3