Add check for version compatibility by building a small sample. #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcamiel
force-pushed
the
feature/add-check-for-binary-compatibility
branch
4 times, most recently
from
18bad93 to
9540996
Compare
jcamiel
force-pushed
the
feature/add-check-for-binary-compatibility
branch
4 times, most recently
from
c63569a to
8a551ff
Compare
jcamiel
changed the title
jcamiel
force-pushed
the
feature/add-check-for-binary-compatibility
branch
from
74cb29d to
b89716b
Compare
jcamiel
force-pushed
the
feature/add-check-for-binary-compatibility
branch
from
b89716b to
589c4c2
Compare
lepapareil
reviewed
Nov 29, 2022
|
/accept |
|
🕗 /accept is running, please wait for completion. |
|
✅ Pull request accepted and closed by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fabricereix @lepapareil
This PR add a new check in the CI.
We build a small sample that can be build with the last released hurl crate. In the CI, we check that this sample can be build using the SNAPSHOT version of hurl crates, without any changes. If this check is not passing, it means that we have broken the API compatibility and must increment hurl crate's major version.
The sample uses most of hurl crate's public structures to detect API changes.
If we detect a major version change in the snapshot version, we bypass this check.
For instance, following #1030 and the additions of two new options, we have to increment major version. We'll use some code pattern soon to allow new options creations without breaking major compatibility.
(see #972)