Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement isEmpty predicate #1356

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

Reachip
Copy link
Member

@Reachip Reachip commented Mar 10, 2023

No description provided.

@jcamiel jcamiel force-pushed the is-empty-predicate branch from c0e5191 to 077807e Compare March 10, 2023 23:00
@jcamiel
Copy link
Collaborator

jcamiel commented Mar 10, 2023

@Reachip still struggle with "Partially verified" when I rebase your branch! It's a mistery, can you check if you have activated "vigilant mode" in your settings ?

Screenshot 2023-03-11 at 00 09 07

(should be under SSH / GPG key settings)
You should let it desactivated in order for GitHub to accept that I rebase and sign on your behalf...

@jcamiel jcamiel self-assigned this Mar 10, 2023
@jcamiel jcamiel force-pushed the is-empty-predicate branch from 077807e to 3fb33a7 Compare March 13, 2023 08:34
Signed-off-by: Rached Mejri <rached.mejri@orange.com>
@jcamiel jcamiel force-pushed the is-empty-predicate branch from 3fb33a7 to 48447ce Compare March 13, 2023 09:12
@jcamiel
Copy link
Collaborator

jcamiel commented Mar 13, 2023

/accept

@hurl-bot
Copy link
Collaborator

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

✅ Pull request accepted and closed by jcamiel with fast forward merge..

# List of commits merged from Reachip/hurl/is-empty-predicate branch into Orange-OpenSource/hurl/master branch:

  • 48447ce Implement isEmpty predicate

@github-actions github-actions bot merged commit 48447ce into Orange-OpenSource:master Mar 13, 2023
@jcamiel
Copy link
Collaborator

jcamiel commented Mar 13, 2023

Thanks @Reachip we finally merge it!

@jcamiel jcamiel linked an issue Mar 13, 2023 that may be closed by this pull request
@jcamiel jcamiel added the enhancement New feature or request label Mar 13, 2023
@jcamiel jcamiel added this to the 3.0.0 milestone Mar 13, 2023
@Reachip Reachip deleted the is-empty-predicate branch March 13, 2023 13:10
@jcamiel jcamiel removed this from the 3.0.0 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asserting "non empty"
3 participants