-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timestamps to the HTML reports #2027
Add timestamps to the HTML reports #2027
Conversation
Thanks for the PR @pit1sIBM. To appease our CI, we need all the commits to be signed (you can check CONTRIBUTING.md). You can see how to do this here , your commit should display a "verified" tag: |
fe65160
to
e04c4e4
Compare
Thanks @jcamiel, should be fixed now. I had some issues with the integration tests locally that I'm looking into but all the |
Missed a crate update, updated the branch |
e04c4e4
to
f2e4023
Compare
@pit1sIBM thanks for the rebase, you haven't to do this, the CI can handle this. Thanks anyway ! |
/accept |
🕗 /accept is running, please wait for completion. |
✅ Pull request merged and closed by
|
Thanks for the PR @pit1sIBM it's merged! |
Issue: #1983
Adds an i64
timestamp
to the HurlResult struct for use in HTML reports to report local start time of each file.Result looks like:
Reports are still updated
For reports created before this change, the timestamp defaults to
0
internally and the report shows a-