Use Template for filename type #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabricereix
force-pushed
the
feature/add-filename-template
branch
from
f83d215 to
ca847d1
Compare
fabricereix
force-pushed
the
feature/add-filename-template
branch
from
ca847d1 to
6ac325d
Compare
|
/accept |
|
🕗 /accept is running, please wait for completion. |
|
✅ Pull request merged and closed by
|
This was
linked to
issues
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filename parsing is implemented like the other strings
with
xxx-content/xxx-text/xxx-escaped-charfunctionshttps://hurl.dev/docs/grammar.html#filename
Note that the grammar/implem will still have to be updated to match exactly.
The
xxx-textfunctions use a blacklist of chars in the grammar where it uses a whitelist of chars in the implem.