Add isNumber predicate

[guerinoni]

Partially closes #2538.

[fabricereix]

To pass the coverage check, you add the new predicate in the file integration/hurlfmt/tests_export/predicate.hurl

[jcamiel]

Hi @guerinoni

You need to signed your commit, to appease the CI (see https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits). You should have something like this:

[guerinoni]

@jcamiel thanks now should be fine with my GPG

[guerinoni]

@fabricereix actually i don't understand why some testing is failing with changes not related to those tests
Help on my error test are appreciated

[fabricereix]

@guerinoni, you probably need to run the test locally to understand what is going on.

[guerinoni]

@guerinoni, you probably need to run the test locally to understand what is going on.

Right now i managed to run bin/coverage.sh, but the documentation says to run integration tests using python3 integration.py and those are giving different expected result as output

[fabricereix]

The failing test is test_ok/help.sh

You simply need to run this script to run this test.

[fabricereix]

You have modified the expected file help.out.pattern

[fabricereix]

You have also modified tests_failed/assert_base64.hurl.
ONLY files related to this new predicate should be modified

[jcamiel]

Hi @guerinoni you should do the following changes in your PR:

• do not modify integration/hurl/test_failed/assert_base64.err
• do not modify integration/hurl/test_ok/help.out.pattern
• do not modify integration/hurlfmt/tests_ok/help.out.pattern

If you want, I can make these changes and your branch and see if all is correct after,

[guerinoni]

Hi @guerinoni you should do the following changes in your PR:

• do not modify integration/hurl/test_failed/assert_base64.err
• do not modify integration/hurl/test_ok/help.out.pattern
• do not modify integration/hurlfmt/tests_ok/help.out.pattern

If you want, I can make these changes and your branch and see if all is correct after,

Yes feel free to push

[jcamiel]

/accept

[hurl-bot]

🕗 /accept is running, please wait for completion.

[hurl-bot]

✅ Pull request merged and closed by jcamiel with fast forward merge..

# List of commits merged from guerinoni/hurl/isNumber branch into Orange-OpenSource/hurl/master branch:

• bc13035 Add isNumber predicate

[jcamiel]

Hi @guerinoni I've rebased and force pushed with tiny changes, everything is OK now. For the PR!