Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support escaped spaces in filenames. #288

Merged
merged 1 commit into from
Oct 17, 2021
Merged

Support escaped spaces in filenames. #288

merged 1 commit into from
Oct 17, 2021

Conversation

youhavethewrong
Copy link
Contributor

This should fix issue #287

@youhavethewrong youhavethewrong changed the title Support spaces in filenames. Support escaped spaces in filenames. Oct 17, 2021
@fabricereix fabricereix linked an issue Oct 17, 2021 that may be closed by this pull request
@fabricereix
Copy link
Collaborator

sorry @youhavethewrong, can you rebase onto master?
thanks

I'm not sure whether all this new escaping should be done in the reader or not. This might be specific to the filename.
We can merge like that for the next release and maybe re-organize the code later one.
Parsing the filename, if it becomes more complicated shoudl probably have its own module/source file.

@youhavethewrong
Copy link
Contributor Author

I agree, it's not ideal to have to update the reader. I've rebased as requested. Thank you!

@fabricereix fabricereix merged commit b76c551 into Orange-OpenSource:master Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support spaces in filenames
2 participants