Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional check for --max-filesize option #3248

Closed
wants to merge 2 commits into from

Conversation

jcamiel
Copy link
Collaborator

@jcamiel jcamiel commented Sep 20, 2024

No description provided.

@jcamiel jcamiel self-assigned this Sep 20, 2024
@jcamiel jcamiel force-pushed the additional-checks-on-max-filesize branch from f675659 to fb1b744 Compare September 20, 2024 13:11
@jcamiel jcamiel linked an issue Sep 20, 2024 that may be closed by this pull request
@jcamiel jcamiel force-pushed the additional-checks-on-max-filesize branch from fb1b744 to b016937 Compare September 20, 2024 13:51
This insures that --max-filesize works even if libcurl < 8.4.0 (see https://curl.se/docs/manpage.html#--max-filesize)
@jcamiel jcamiel force-pushed the additional-checks-on-max-filesize branch from 43e505d to c92df5a Compare September 20, 2024 14:58
@jcamiel jcamiel marked this pull request as ready for review September 20, 2024 15:24
@jcamiel
Copy link
Collaborator Author

jcamiel commented Sep 20, 2024

/accept

@hurl-bot
Copy link
Collaborator

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

✅ Pull request merged and closed by jcamiel with fast forward merge..

# List of commits merged from Orange-OpenSource/hurl/additional-checks-on-max-filesize branch into Orange-OpenSource/hurl/master branch:

  • c92df5a Add additional check on maximum response size.
  • b016937 Add additional check for --max-filesize integration test.

@hurl-bot hurl-bot closed this Sep 20, 2024
@hurl-bot hurl-bot deleted the additional-checks-on-max-filesize branch September 20, 2024 15:33
@jcamiel
Copy link
Collaborator Author

jcamiel commented Sep 20, 2024

Fixes #3245

@jcamiel jcamiel changed the title Add additional check for --max-filesize integration test. Add additional check for --max-filesize integration test Sep 20, 2024
@jcamiel jcamiel changed the title Add additional check for --max-filesize integration test Add additional check for --max-filesize option Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI option --max-filesize not always enforced
2 participants