Check protocol at runtime #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabricereix
force-pushed
the
check/protocol-at-runtime
branch
2 times, most recently
from
d1ed04b to
9848c92
Compare
|
/accept |
|
🕗 /accept is running, please wait for completion. |
|
🔨 Auto rebase from
|
|
🕗 /accept is still running, please wait for completion. |
hurl-bot
force-pushed
the
check/protocol-at-runtime
branch
from
9848c92 to
c62fb43
Compare
|
✅ Pull request merged and closed by
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added the check that if a protocol is given, it must be either
httporhttps.The existing behavior that a protocol must be given explicitly does not change in this PR
hurl --variable host=localhost:8000 tests_failed/invalid_url_1.hurlBut we should change this behavior in a following PR.
The url could have a default protocol, such as
http(curl-like) orhttps(browser-like)