Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create parent folders if missing when using --cookie-jar FILE #3688

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

uday-rana
Copy link
Contributor

Fixes #3637

Please let me know if there's anything I could improve. Thanks.

@uday-rana uday-rana marked this pull request as ready for review February 3, 2025 00:47
@jcamiel jcamiel self-requested a review February 3, 2025 12:42
packages/hurl/src/main.rs Outdated Show resolved Hide resolved
@uday-rana uday-rana requested a review from jcamiel February 3, 2025 20:01
@jcamiel
Copy link
Collaborator

jcamiel commented Feb 3, 2025

Good job @uday-rana thanks for the PR

@jcamiel
Copy link
Collaborator

jcamiel commented Feb 4, 2025

/accept

@hurl-bot
Copy link
Collaborator

hurl-bot commented Feb 4, 2025

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

hurl-bot commented Feb 4, 2025

🔨 Auto rebase from Orange-OpenSource/hurl/master succeeds, uday-rana/hurl/issue-3637 now embeds these commits:

@hurl-bot
Copy link
Collaborator

hurl-bot commented Feb 4, 2025

🕗 /accept is still running, please wait for completion.

@hurl-bot
Copy link
Collaborator

hurl-bot commented Feb 4, 2025

❌ Some checks are still failing, please fix them before trying to merge this pull request.

@jcamiel
Copy link
Collaborator

jcamiel commented Feb 5, 2025

/accept

@hurl-bot
Copy link
Collaborator

hurl-bot commented Feb 5, 2025

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

hurl-bot commented Feb 5, 2025

✅ Pull request merged with fast forward by jcamiel..

# List of commits merged from uday-rana/hurl/issue-3637 branch into Orange-OpenSource/hurl/master branch:

  • ea1a7b7 Use util function for creating parent folders for curl export
  • 6e1f421 Use util function for creating parent folders for TAP report
  • c2da541 Use util function for creating parent folders for JUnit reports
  • f0bf4cd Extract parent folder creation logic to util function
  • 501aadf Create parent folders if missing when using --cookie-jar FILE

@hurl-bot hurl-bot merged commit ea1a7b7 into Orange-OpenSource:master Feb 5, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--cookie-jar FILE doesn't work if intermediate directories don't exist
3 participants