-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python/iot3: add bootstrap #250
python/iot3: add bootstrap #250
Conversation
Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
27d97a5
to
3b3dc3a
Compare
A little typing error in "bootstrap" in commit dba89fe title |
To have the expected result 3, I think we have to add something like
at the end of the file tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and tests are Ok for me.
Just a commit title to fix and a line to add in test files (or changing the expected result 3 to check)
3b3dc3a
to
6f586b1
Compare
Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
6f586b1
to
7cdc7c4
Compare
Gah, I forgot to push... :-/ There, it is in now... (the output is JSON, not what |
Yes it is why I suggested 'pprint' not 'print' |
Sorry a very little wording in a commit message I have not seen yesterday: in last commit: 'acutal' vs 'actual' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very little wording in a commit message
>>> pprint(config)
Traceback (most recent call last):
File "<string>", line 1, in <module>
NameError: name 'pprint' is not defined. Did you mean: 'print'? (it needs |
We introduce a plain, basic test that just verifies that the bootstrap() method returns an object with the expected fields. Doing a complete test would require a stable bootstrap server that returns actual connection details, not the stub we currently have available... Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
7cdc7c4
to
0e057dc
Compare
Features:
Preparation:
python/iot3/tests/test-iot3-core-bootstrap
andpython/iot3/tests/test-iot3-mobility-bootstrap
with the details of your bootstrap manager, notably the host, port, endpoint, credentials...How to test:
Expected results: