-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: fix installed scripts #256
python: fix installed scripts #256
Conversation
Commit 81ff4ce (python/its-iqm: migrate to PEP517) copied the pyproject.toml from the its-vehicle package, as a starting point. In doing so, it forgot to rename the installed script, and to update its entrypoint as well. Fix that now. Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
Commit 5da7ecd (python/its-status: migrate to PEP517) copied the pyproject.toml from the its-info package as a starting point. In doing so, it forgot to rename the installed script, and to update its entrypoint as well. Fix that now. Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
@ymorin-orange I've been following the full procedure - using a container -, but I am running into the following error after running
Should the container be started with |
This is due to a discrepancy between using a "normal" Docker installation vs. Docker Desktop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After fixing docker configuration issues on the test machine (should use docker.io and not docker desktop):
Test 1
its-interqueuemanager package install successful.
Command /tmp/iqm/bin/its-iqm -h
shows:
usage: its-iqm [-h] [--config CONFIG] [--debug]
options:
-h, --help show this help message and exit
--config CONFIG, -c CONFIG
Path to the configuration file (default: /etc/its/iqm.cfg)
--debug Print tons of debug messages on stderr
Test 2
its-status package install successful.
Command /tmp/status/bin/its-status -h
shows:
usage: its-status [-h] [--config CONFIG]
options:
-h, --help show this help message and exit
--config CONFIG, -c CONFIG
Path to the configuration file (default: /etc/its-status/its-status.cfg)
Test 3
its-vehicle package install successful.
Command /tmp/vehicle/bin/its-vehicle -h
shows:
usage: its-vehicle [-h] [--config CONFIG] [--debug]
options:
-h, --help show this help message and exit
--config CONFIG, -c CONFIG
Path to the configuration file (default: /etc/its/vehicle.cfg)
--debug, -d Enable debug messages
PR is approved 👍
Changes:
How to test:
Pre-requisites:
$
prompt means running in a shell that has access to python3.11, while the🐍 $
prompt means running in the activated venv.$ python3.11 -m venv /tmp/iqm $ . /tmp/iqm/bin/activate 🐍 $ pip install python/its-interqueuemanager 🐍 $ /tmp/iqm/bin/its-iqm -h 🐍 $ deactivate
$ python3.11 -m venv /tmp/status $ . /tmp/status/bin/activate 🐍 $ pip install python/its-status 🐍 $ /tmp/status/bin/its-status -h 🐍 $ deactivate
$ python3.11 -m venv /tmp/vehicle $ . /tmp/vehicle/bin/activate 🐍 $ pip install linuxfd==1.5 python/iot3 🐍 $ pip install --no-deps python/its-vehicle 🐍 $ /tmp/vehicle/bin/its-vehicle -h 🐍 $ deactivate
Expected results:
its-iqm
;its-iqm -h
displays help forits-iqm
.its-status
;its-status -h
displays help forits-status
.its-status
;its-vehicle -h
displays help forits-vehicle
.