Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read properties of undefined error? #116

Closed
TheFreshPrins opened this issue Nov 5, 2022 · 4 comments
Closed

Cannot read properties of undefined error? #116

TheFreshPrins opened this issue Nov 5, 2022 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@TheFreshPrins
Copy link

TheFreshPrins commented Nov 5, 2022

Sometime during the day I get the following error: https://photos.app.goo.gl/UXLZLb7JzqTYkt1R6

Any solution for this problem?

Some additional information;
*Clean windows installation without a previous Aerial install
*The screen looks "stuck" and you can't click on anything untill you press the Win key
*One monitor setup

Thanks!

@OrangeJedi
Copy link
Owner

Sorry to hear that Aerial isn't working. How often have you gotten this error? Is it when the screensaver is just running on its own, or after you try and interact with it? Does it crash the screensaver, or just pop up with the error?

It looks like the code that is checking to see if the window is closed isn't working. I'll take a closer look soon and see why that may be the case.

@OrangeJedi OrangeJedi added the bug Something isn't working label Nov 7, 2022
@TheFreshPrins
Copy link
Author

Sorry to hear that Aerial isn't working. How often have you gotten this error? Is it when the screensaver is just running on its own, or after you try and interact with it? Does it crash the screensaver, or just pop up with the error?

It looks like the code that is checking to see if the window is closed isn't working. I'll take a closer look soon and see why that may be the case.

Hey there, thanks for the quick reply. The error causes to crash the screensaver. It only happens on its own. I didn't configure anything yet.

It didn't happen the last few days to be honest. Don't know why.

I tried adding some custom video's like in V0.5.4, but they don't show up after converting them in VLC to MPEG4 1080P for TV/Device. Did you rewrite the custom video section of the application with some changes?

Thanks in advance!

@OrangeJedi
Copy link
Owner

Ok, thanks for the extra info. When I get the time I'll see if I can find anything that caused the initial error with the windows close. Also, none of the code for custom videos changed from v0.5.4, but I also wasn't able to get it working. I will take a look at that code too.

OrangeJedi added a commit that referenced this issue Nov 9, 2022
Added an extra check to prevent the error from #116
@OrangeJedi OrangeJedi added this to the v1.1.0 milestone Nov 9, 2022
@OrangeJedi
Copy link
Owner

I ended up having some time tonight to go through the code. I wasn't able to pinpoint for certain why the original read proprieties of undefined happened, but I added some code that should prevent it for happening again to the v1.1.0 branch/release. I also found the problem with the custom videos, while the code didn't change, a few libraries were updated that caused some runtime errors to occur. I was able to fix those and get custom videos working again in v1.1.0.

Thanks for bringing this up! I'm glad that these two things were able to be fixed.

@irampton irampton mentioned this issue Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants