Remove warnings related to CA1805

* Member is explicitly initialized to its default value

Directory.Build.props

@@ -9,9 +9,6 @@
 
  <AnalysisLevel>latest-Recommended</AnalysisLevel>
 
- <!-- Member is explicitly initialized to its default value -->
- <NoWarn>$(NoWarn);CA1805</NoWarn>
-
  <!-- The behavior could vary based on the current user's locale setting -->
  <NoWarn>$(NoWarn);CA1304;CA1305;CA1310</NoWarn>
 

src/OrchardCore.Modules/OrchardCore.ContentLocalization/Models/ContentCulturePickerSettings.cs

@@ -2,7 +2,7 @@ namespace OrchardCore.ContentLocalization.Models
 {
  public class ContentCulturePickerSettings
  {
- public bool RedirectToHomepage { get; set; } = false;
+ public bool RedirectToHomepage { get; set; }
  public bool SetCookie { get; set; } = true;
  }
 }

src/OrchardCore.Modules/OrchardCore.Facebook/Settings/FacebookSettings.cs

@@ -4,7 +4,7 @@ public class FacebookSettings
  {
  public string AppId { get; set; }
  public string AppSecret { get; set; }
- public bool FBInit { get; set; } = false;
+ public bool FBInit { get; set; }
 
  public string FBInitParams { get; set; } = @"status:true,
 xfbml:true,

src/OrchardCore.Modules/OrchardCore.Liquid/ScriptsMiddleware.cs

@@ -19,7 +19,7 @@ public class ScriptsMiddleware
  {
  private readonly RequestDelegate _next;
 
- byte[] _bytes = null;
+ byte[] _bytes;
  string _etag;
 
  public ScriptsMiddleware(RequestDelegate next)

src/OrchardCore.Modules/OrchardCore.Notifications/Drivers/NotifyUserTaskActivityDisplayDriver.cs

@@ -26,7 +26,7 @@ public abstract class NotifyUserTaskActivityDisplayDriver<TActivity, TEditViewMo
 
  protected readonly IStringLocalizer S;
 
- protected virtual string EditShapeType { get; } = null;
+ protected virtual string EditShapeType { get; }
 
  public NotifyUserTaskActivityDisplayDriver(
  IHtmlSanitizerService htmlSanitizerService,
@@ -163,5 +163,5 @@ public NotifyUserTaskActivityDisplayDriver(
  {
  }
 
- sealed protected override string EditShapeType { get; } = null;
+ protected sealed override string EditShapeType { get; }
 }

src/OrchardCore.Modules/OrchardCore.Placements/ViewModels/EditShapePlacementViewModel.cs

@@ -2,7 +2,7 @@ namespace OrchardCore.Placements.ViewModels
 {
  public class EditShapePlacementViewModel
  {
- public bool Creating { get; set; } = false;
+ public bool Creating { get; set; }
 
  public string ShapeType { get; set; }
 

src/OrchardCore.Modules/OrchardCore.Roles/Services/RolesPermissionsHandler.cs

@@ -16,7 +16,8 @@ public class RolesPermissionsHandler : AuthorizationHandler<PermissionRequiremen
  private readonly IPermissionGrantingService _permissionGrantingService;
 
 
- private IEnumerable<RoleClaim> _anonymousClaims = null, _authenticatedClaims = null;
+ private IEnumerable<RoleClaim> _anonymousClaims;
+ private IEnumerable<RoleClaim> _authenticatedClaims;
 
  public RolesPermissionsHandler(
  RoleManager<IRole> roleManager,

src/OrchardCore.Modules/OrchardCore.Search.Lucene/Model/LuceneSettings.cs

@@ -15,6 +15,6 @@ public class LuceneSettings
 
  public string[] DefaultSearchFields { get; set; } = FullTextField;
 
- public bool AllowLuceneQueriesInSearch { get; set; } = false;
+ public bool AllowLuceneQueriesInSearch { get; set; }
  }
 }

src/OrchardCore.Modules/OrchardCore.Search.Lucene/Recipes/LuceneIndexRebuildStep.cs

@@ -49,7 +49,7 @@ await HttpBackgroundJob.ExecuteAfterEndOfRequestAsync("lucene-index-rebuild", as
 
  private sealed class LuceneIndexRebuildStepModel
  {
- public bool IncludeAll { get; set; } = false;
+ public bool IncludeAll { get; set; }
  public string[] Indices { get; set; } = [];
  }
  }

src/OrchardCore.Modules/OrchardCore.Search.Lucene/Recipes/LuceneIndexResetStep.cs

@@ -55,7 +55,7 @@ await HttpBackgroundJob.ExecuteAfterEndOfRequestAsync("lucene-index-reset", asyn
 
  private sealed class LuceneIndexResetStepModel
  {
- public bool IncludeAll { get; set; } = false;
+ public bool IncludeAll { get; set; }
  public string[] Indices { get; set; } = [];
  }
  }

src/OrchardCore/OrchardCore.Abstractions/Modules/Manifest/FeatureAttribute.cs

@@ -335,7 +335,7 @@ internal virtual string Categorize(params FeatureAttribute[] additionalFeatures)
  /// <summary>
  /// Once enabled, check whether the feature cannot be disabled. Defaults to <c>false</c>.
  /// </summary>
- public virtual bool IsAlwaysEnabled { get; set; } = false;
+ public virtual bool IsAlwaysEnabled { get; set; }
 
  /// <summary>
  /// Set to <c>true</c> to make the feature available by dependency only.

src/OrchardCore/OrchardCore.Abstractions/Modules/StartupBase.cs

@@ -9,7 +9,7 @@ namespace OrchardCore.Modules
  public abstract class StartupBase : IStartup, IAsyncStartup
  {
  /// <inheritdoc />
- public virtual int Order { get; } = 0;
+ public virtual int Order { get; }
 
  /// <inheritdoc />
  public virtual int ConfigureOrder => Order;

src/OrchardCore/OrchardCore.Apis.GraphQL.Abstractions/GraphQLSettings.cs

@@ -9,7 +9,7 @@ public class GraphQLSettings
  public PathString Path { get; set; } = "/api/graphql";
  public Func<HttpContext, IDictionary<string, object>> BuildUserContext { get; set; }
 
- public bool ExposeExceptions { get; set; } = false;
+ public bool ExposeExceptions { get; set; }
 
  public int? MaxDepth { get; set; }
  public int? MaxComplexity { get; set; }

src/OrchardCore/OrchardCore.DisplayManagement/Shapes/Shape.cs

@@ -14,7 +14,7 @@ namespace OrchardCore.DisplayManagement.Shapes
  [DebuggerTypeProxy(typeof(ShapeDebugView))]
  public class Shape : Composite, IShape, IPositioned, IEnumerable<object>
  {
- private bool _sorted = false;
+ private bool _sorted;
 
  public ShapeMetadata Metadata { get; } = new ShapeMetadata();
 

src/OrchardCore/OrchardCore.DisplayManagement/Views/ShapeViewModel.cs

@@ -49,7 +49,7 @@ public string Position
 
  public IDictionary<string, object> Properties => _properties ??= [];
 
- private bool _sorted = false;
+ private bool _sorted;
 
  private List<IPositioned> _items;
 

src/OrchardCore/OrchardCore.FileStorage.AzureBlob/BlobFileStore.cs

@@ -44,7 +44,7 @@ public class BlobFileStore : IFileStore
  private readonly IClock _clock;
  private readonly BlobContainerClient _blobContainer;
  private readonly IContentTypeProvider _contentTypeProvider;
- private readonly string _basePrefix = null;
+ private readonly string _basePrefix;
 
  public BlobFileStore(BlobStorageOptions options, IClock clock, IContentTypeProvider contentTypeProvider)
  {

src/OrchardCore/OrchardCore.Localization.Core/DataAnnotations/DataAnnotationsDefaultErrorMessages.cs

@@ -8,7 +8,9 @@ namespace OrchardCore.Localization.DataAnnotations
  internal sealed class DataAnnotationsDefaultErrorMessages
  {
 #pragma warning disable IDE1006 // Naming Styles
- private readonly IStringLocalizer S = null;
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
+ private readonly IStringLocalizer S;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 #pragma warning restore IDE1006 // Naming Styles
 
  public string AssociatedMetadataTypeTypeDescriptorMetadataTypeContainsUnknownProperties => S["The associated metadata type for type '{0}' contains the following unknown properties or fields: {1}. Please make sure that the names of these members match the names of the properties on the main type."];

src/OrchardCore/OrchardCore.Search.AzureAI.Core/Deployment/AzureAISearchIndexResetDeploymentStep.cs

@@ -9,7 +9,7 @@ public AzureAISearchIndexResetDeploymentStep()
  Name = "AzureAISearchIndexReset";
  }
 
- public bool IncludeAll { get; set; } = false;
+ public bool IncludeAll { get; set; }
 
  public string[] Indices { get; set; }
 }

src/OrchardCore/OrchardCore.Search.AzureAI.Core/Models/AzureAISearchIndexSettings.cs

@@ -21,7 +21,7 @@ public class AzureAISearchIndexSettings
 
  public IList<AzureAISearchIndexMap> IndexMappings { get; set; }
 
- private long _lastTaskId = 0;
+ private long _lastTaskId;
 
  public long GetLastTaskId()
  => _lastTaskId;

src/OrchardCore/OrchardCore.Search.Elasticsearch.Core/Models/ElasticConnectionOptions.cs

@@ -42,7 +42,7 @@ public class ElasticConnectionOptions
  /// <summary>
  /// Enables compatibility mode for Elasticsearch 8.x.
  /// </summary>
- public bool EnableApiVersioningHeader { get; set; } = false;
+ public bool EnableApiVersioningHeader { get; set; }
 
  /// <summary>
  /// Whether the configuration section exists.

src/OrchardCore/OrchardCore.Users.Core/Services/DefaultTwoFactorAuthenticationHandlerCoordinator.cs

@@ -8,7 +8,7 @@ public class DefaultTwoFactorAuthenticationHandlerCoordinator : ITwoFactorAuthen
 {
  private readonly IEnumerable<ITwoFactorAuthenticationHandler> _twoFactorAuthenticationHandlers;
 
- private bool? _isRequired = null;
+ private bool? _isRequired;
 
  public DefaultTwoFactorAuthenticationHandlerCoordinator(
  IEnumerable<ITwoFactorAuthenticationHandler> twoFactorAuthenticationHandlers)

src/OrchardCore/OrchardCore/Shell/RunningShellTable.cs

@@ -11,7 +11,7 @@ public class RunningShellTable : IRunningShellTable
  {
  private ImmutableDictionary<string, ShellSettings> _shellsByHostAndPrefix = ImmutableDictionary<string, ShellSettings>.Empty.WithComparers(StringComparer.OrdinalIgnoreCase);
  private ShellSettings _default;
- private bool _hasStarMapping = false;
+ private bool _hasStarMapping;
 
  public void Add(ShellSettings settings)
  {

test/OrchardCore.Tests/Apis/Context/AuthenticationContext.cs

@@ -93,7 +93,7 @@ public class PermissionsContext
  {
  public IEnumerable<Permission> AuthorizedPermissions { get; set; } = [];
 
- public bool UsePermissionsContext { get; set; } = false;
+ public bool UsePermissionsContext { get; set; }
  }
 
  internal sealed class StubIdentity : IIdentity