Skip to content

Commit

Permalink
Fix Publish Content Task (#17033)
Browse files Browse the repository at this point in the history
  • Loading branch information
MikeAlhayek authored Nov 18, 2024
1 parent d03b3b4 commit bdf74c8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public override async Task<ActivityExecutionResult> ExecuteAsync(WorkflowExecuti
var content = (await GetContentAsync(workflowContext))
?? throw new InvalidOperationException($"The '{nameof(PublishContentTask)}' failed to retrieve the content item.");

if (string.Equals(InlineEvent.ContentItemId, content.ContentItem.ContentItemId, StringComparison.OrdinalIgnoreCase))
if (!content.HasDraft())
{
return Outcomes("Noop");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -563,16 +563,17 @@ public async Task CreateAsync(ContentItem contentItem, VersionOptions options =

options ??= VersionOptions.Published;

// Draft flag on create is required for explicitly-published content items
// Draft flag on create is required for explicitly-published content items.
if (options.IsDraft)
{
contentItem.Published = false;
contentItem.Latest = true;
}

// Build a context with the initialized instance to create
// Build a context with the initialized instance to create.
var context = new CreateContentContext(contentItem);

// invoke handlers to add information to persistent stores
// invoke handlers to add information to persistent stores.
await Handlers.InvokeAsync((handler, context) => handler.CreatingAsync(context), context, _logger);

await _session.SaveAsync(contentItem);
Expand All @@ -584,10 +585,10 @@ public async Task CreateAsync(ContentItem contentItem, VersionOptions options =
{
var publishContext = new PublishContentContext(contentItem, null);

// invoke handlers to acquire state, or at least establish lazy loading callbacks
// invoke handlers to acquire state, or at least establish lazy loading callbacks.
await Handlers.InvokeAsync((handler, context) => handler.PublishingAsync(context), publishContext, _logger);

// invoke handlers to acquire state, or at least establish lazy loading callbacks
// invoke handlers to acquire state, or at least establish lazy loading callbacks.
await ReversedHandlers.InvokeAsync((handler, context) => handler.PublishedAsync(context), publishContext, _logger);
}
}
Expand Down

0 comments on commit bdf74c8

Please sign in to comment.