Scripting - JInt - Is it possible to show the line where the error was thrown?

[weirdyang]

Using the javascript scripting workflow task, is it possible to show which line or variable that causes an error?

[hishamco]

This might be a question for Jint repo

/cc @lahma @hyzx86

[weirdyang]

Thanks, so I guess i would have to implement my own script task or script evaluator

[hyzx86]

Yes, Jint supports this operation

          var engine = new Engine(options =>
          {
              options.Interop.ExceptionHandler = ex =>
              {
//Determines the type of exception to be handled by Jint based on the exception information. 
                  Console.WriteLine(ex.Message);
                  return true;
              };
           }

[hyzx86]

I believe that is already done by default,

This is not the default, probably because sometimes exceptions may contain confidential information.

[weirdyang]

I see, I assumed the fault message was the exception

[hyzx86]

I see, I assumed the fault message was the exception

You don't have to do anything, just try catch. . I think in your scene,

[weirdyang]

Hmm looking at the script evaluator used by the workflow script task, I don't see where it hides the exception? https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Workflows/Scripting/JavaScriptWorkflowScriptEvaluator.cs

I don't see it in the engine too

https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore/OrchardCore.Scripting.JavaScript/JavaScriptEngine.cs

[hyzx86]

What kind of exception did you encounter? Is it possible that this extension function has been processed internally?

[weirdyang]

FOr anyone who is trying to do this, wrap the evaluate method in a try catch and catch JavaScriptException, it has a Location property

I did not need to modify engine options.

            try
            {
                workflowContext.LastResult = await _scriptEvaluator.EvaluateAsync(Script, workflowContext, new OutcomeMethodProvider(outcomes));

            }
            catch (JavaScriptException ex)
            {
                // throw custom exception
                throw new InvalidOperationException(string.Format("Error at Line:{0} Column: {1} | {2}",
                    ex.Location.Start.Line,
                    ex.Location.Start.Column,
                    ex.Message), ex);

            }

[hyzx86]

Yes, but it should need to work with the options above, otherwise it won't throw the exception position in the custom function

[weirdyang]

Hmm it seems to be working correctly out of the box though didn't need to use any options. I just modified the default script task without changing any options, happy to be proven otherwise though, let me know if you have a sample to show what you mean

[hyzx86]

Really? As I recall, when an extension reports an error internally, it doesn't indicate the location of the script where the error occurred, e.g. if you make an extension that handles excel, if excel doesn't exist, it will throw an IO exception without including the exact location of the script.

[weirdyang]

Yeap I think it’s cos it’s using Jint, and the engine itself is throwing the exception. So you have to catch the specific exception to case it to JavascrptException.

…

On Tue, 16 Jul 2024 at 5:03 PM, Tony Han ***@***.***> wrote: Really? As I recall, when an extension reports an error internally, it doesn't indicate the location of the script where the error occurred, e.g. if you make an extension that handles excel, if excel doesn't exist, it will throw an IO exception without including the exact location of the script. — Reply to this email directly, view it on GitHub <#16357 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGDEEVTFJ4WM675SXZJMAP3ZMTOXRAVCNFSM6AAAAABJVN5CXCVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAMBWGAYTKNA> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>