Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Navbar shape to allow other to easily inject item into the top navigation bar #14487

Closed
MikeAlhayek opened this issue Oct 11, 2023 · 7 comments · Fixed by #14488
Closed
Milestone

Comments

@MikeAlhayek
Copy link
Member

Is your feature request related to a problem? Please describe.

It is hard to current inject custom items into the Navbar. We also seems to have multiple shapes to act as menu items.

Introduce a single Navbar shape like we did in UserMenu which allow us to easily inject items using driver instead of global filters.

@agriffard
Copy link
Member

The front displays the culture picker with a dropdownmenu (the text is the current culture and the list contains the other cultures):

image

while the admin uses a select dropdownlist (with all cultures)

image

Should we also use a dropdown menu in admin?

@agriffard
Copy link
Member

If we can a have the razor/liquid equivalent of each shape in the docs (like we did for the AdminBranding), that would be great.

@MikeAlhayek
Copy link
Member Author

MikeAlhayek commented Oct 12, 2023

Should we also use a dropdown menu in admin?

I agree that we should. But, maybe in a separate PR. In the PR I submitted, the idea was to introduce the Navbar and inject the shapes when the modules are enabled.

If we can a have the razor/liquid equivalent of each shape in the docs (like we did for the AdminBranding), that would be great.

There are too many items to document. Is there a specific shape you want to document? It's like anything else in OC. Not sure if we want to document every shape

@agriffard
Copy link
Member

I mean the Navbar shapes: VisitSiteNavbarItem for example.

@MikeAlhayek
Copy link
Member Author

@agriffard where would you document that? release notes?

@agriffard
Copy link
Member

There is this example but it is for the admin module, not TheAdminTheme that does not have a dedicated page:
https://docs.orchardcore.net/en/latest/docs/reference/modules/Admin/#customize-admin-branding

There is this page, but this is to create a custom admin theme:
https://docs.orchardcore.net/en/latest/docs/guides/create-admin-theme/

@MikeAlhayek
Copy link
Member Author

MikeAlhayek commented Oct 12, 2023

@agriffard I added the docs.

@MikeAlhayek MikeAlhayek added this to the 1.x milestone Nov 3, 2023
@MikeAlhayek MikeAlhayek modified the milestones: 1.x, 1.8 Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants