Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for Script and Style tag helpers #15504

Open
Skrypt opened this issue Mar 13, 2024 · 2 comments
Open

Add unit tests for Script and Style tag helpers #15504

Skrypt opened this issue Mar 13, 2024 · 2 comments
Labels
enhancement Needs Unit Test(s) Unit Tests or Functional Tests are required P2
Milestone

Comments

@Skrypt
Copy link
Contributor

Skrypt commented Mar 13, 2024

We need to add unit test to test for these:

A script or a style tag that has a type="module" param should not spread it to it's set script dependencies.
A script or a style tag that has a At="Footer" should spread to it's dependencies (Location on tag helper).

Example of ScriptTagHelper unit test: https://github.com/dotnet/aspnetcore/blob/main/src/Mvc/Mvc.TagHelpers/test/ScriptTagHelperTest.cs

Did start working on it last night based on that file.

@Piedone
Copy link
Member

Piedone commented Mar 13, 2024

Related: #15438.

@sebastienros sebastienros added this to the 1.x milestone Mar 14, 2024
@Piedone Piedone modified the milestones: 2.x, 2.1 May 3, 2024
@Piedone Piedone added the Needs Unit Test(s) Unit Tests or Functional Tests are required label May 29, 2024
@MikeAlhayek MikeAlhayek modified the milestones: 2.1, 2.x Nov 12, 2024
@MikeAlhayek MikeAlhayek added the P2 label Nov 12, 2024
Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Needs Unit Test(s) Unit Tests or Functional Tests are required P2
Projects
None yet
Development

No branches or pull requests

4 participants