Fix script tag helper dependencies inheriting the script's HTML attributes #15438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngs so let's bring it in to DRY.
…to script-tag-helper-attributes
|
I don't remember exactly why we were inheriting these script tag properties. I hope it won't break anything else. Maybe we should have unit tests to make sure that we cover the specs that were needed ... if we ever find them. That's why unit tests are always helpful. At least, we then know which user cases it needs to cover. Now, we don't really know. |
|
To be fair this setting inheritance was set up 8 years ago in the same PR where the |
|
Yeah and it was copied from Orchard 1 so add another 10 years on that. 😄 |
|
Yeah, I've looked into it and guess what?
|
Skrypt
reviewed
Mar 5, 2024
src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs
Show resolved
Hide resolved
Skrypt
approved these changes
Mar 5, 2024
This was referenced Mar 13, 2024
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
This was referenced Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also some code cleanup in
ScriptTagHelperto keep it DRY.Fixes #15375