-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure EnableThreadSafetyChecks for functional tests too #16006
Labels
Milestone
Comments
Piedone
added
enhancement
Needs Unit Test(s)
Unit Tests or Functional Tests are required
labels
May 7, 2024
Related: #12834. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
The new YesSql option,
EnableThreadSafetyChecks
, is enabled for some integrations tests. This is good, because it'll make issues like #15794 and #15628 more apparent by directly failing the tests. However, this is also needed for functional tests for the same reason.Describe the solution you'd like
Most possibly, we need to pass a parameter to the web app when running it here, and bind it to
EnableThreadSafetyChecks
out of the box. Then, we also need to update the default appsettings.json with an example (but it should still be off by default).Describe alternatives you've considered
I thought about not binding the config by default, but then we'd need to do some testing-specific change in the codebase still.
The text was updated successfully, but these errors were encountered: