IndexPrefix setting for ElasticSearch does not work for Queries and ElasticContentPicker

[AndreySurkov]

Describe the bug

When IndexPrefix setting for ElasticSearch set in config, Elastic Search Query and ElasticContentPicker functionality do not work.

Orchard Core version

1.8.2

To Reproduce

Steps to reproduce the behavior:

1. Set IndexPrefix in config to "dev"
2. Go to ElasticSearch Indexes and create index "pages". ( phisical name of index will be dev_default_pages )
3. Configure index and make shure that documents added to index
4. On "ElasticSearch Indexes" page press "Query" button for "pages" index and execute match_all request.
5. Results are empty/

Expected behavior

Documents from pages (dev_default_pages ) index should be displayed in results.

Dev details

Current implementation of OrchardCore.Search.ElasticSearch.Core assembly contains three places for direct manipulation with IElasticClient.

• OrchardCore.Search.Elasticsearch.Core.Services.ElasticIndexManager
• OrchardCore.Search.Elasticsearch.Core.Services.ElasticQueryService
• OrchardCore.Search.Elasticsearch.Core.Providers.ElasticContentPickerResultProvider

All listed clasees have its own code for building final name of index that will be used in ES.

Proposal

Refactor current code to isolate all manipulation with IElasticClient in single class.

[AndreySurkov]

I refactor a bit code to fix this #16422. Could someone take a look please?

[github-actions]

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.