-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Culture and supported_cultures #16675
Comments
We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues). This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here. |
@hishamco Wondering if it would make sense to expose And another comment about something that might not work with the recent PR we merged, we should be able to pipeline |
Could be, but it might be confusing to have supported cultures inside culture, what about
Let me start a new PR and ping you then |
@sebastienros I'm not sure if it's doable now after you removed the |
Almost done on my side |
I will wait for your PR, coz I already working on a new branch :) I will save the time and wait until you push your PR |
In this PR #16208
Culture
was introduced to represent the selected culture for the context. We should just be able to return a new ObjectValue with the current culture in it and not have to proxy every property sinceCultureInfo
is already registered.supported_cultures
should not be a filter, because it's not using theinput
. We could pass anything to it and it would still work. I suggest we register a FluidValue likeSupportedCultures
so we can writefor cultures in SupportedCultures
.XXXFluidAccessor
then register it, likeEnvironment
,Culture
, ...The text was updated successfully, but these errors were encountered: