Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protection Key is not removed during tenant removal #16799

Closed
MikeAlhayek opened this issue Sep 25, 2024 · 3 comments · Fixed by #16839
Closed

Protection Key is not removed during tenant removal #16799

MikeAlhayek opened this issue Sep 25, 2024 · 3 comments · Fixed by #16839
Milestone

Comments

@MikeAlhayek
Copy link
Member

Describe the bug

When we remove a tenant using the UI, the database and the host container are cleared of the tenant. But the Protection key is not removed.

Orchard Core version

Add the version of the Orchard Core NuGet packages you use, or the commit hash if you can reproduce this with the source code.

To Reproduce

Steps to reproduce the behavior:

  1. Create a tenant
  2. Set it up
  3. Disable it
  4. Remove it
  5. Check the protection key DataProtectionKeys.xml it will exists. I tested this when data protection are stored in Azure Blob storage "not sure if locally we have the same problem".

Expected behavior

I would expect everything related to the tenant being removed to be removed.

@agriffard agriffard changed the title Protication Key is not removed during tenant removal Protection Key is not removed during tenant removal Sep 25, 2024
@Piedone
Copy link
Member

Piedone commented Sep 30, 2024

Related: #16403

@sebastienros
Copy link
Member

Same solution as the related issue, create an IShellRemovingHandler to handle it. And for any data protection provider.

@sebastienros sebastienros added this to the 2.x milestone Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants