Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data protection keys from Azure blob storage when deleting tenant #16839

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

microposmp
Copy link
Contributor

Fixes #16799

@hishamco hishamco requested a review from Piedone October 6, 2024 20:42
@Piedone
Copy link
Member

Piedone commented Oct 7, 2024

When addressing review feedback, please adhere to the following:

  • Please update your pull request according to feedback until it is approved by one of the core team members.
  • Apply suggested changes directly so the reviewer doesn't have to eyeball the changes. These resolve themselves after applying them, and that's fine.
  • Don't resolve other conversations so it's easier to track for the reviewer. Then, the reviewer will resolve them.
  • Feel free to mark conversations that you addressed to keep track of them with an emoji or otherwise, just don't resolve them.
  • Please keep conversations happening in line comments in those convos, otherwise, communication will be a mess. If you have trouble finding them, see this video.
  • When you're done addressing all feedback of a review, click "Re-request review" in the top-right corner for each reviewer when you're ready for another round of review, so they know that you're done.

@microposmp microposmp requested a review from Piedone October 7, 2024 14:43
@microposmp microposmp requested a review from MikeAlhayek October 7, 2024 18:23
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@microposmp microposmp requested a review from Piedone October 7, 2024 20:12
@MikeAlhayek
Copy link
Member

@microposmp did you try it with a live connection to Azure to ensure it is removing the correct file for the tenant only?

@microposmp
Copy link
Contributor Author

Yes I've tested it against Azure blob storage. Here are a few screenshots from before and after deleting a tenant.

Before:

image

image

image

After:

image

image

@Piedone Piedone merged commit 8de0e71 into OrchardCMS:main Oct 8, 2024
46 checks passed
@microposmp microposmp deleted the #16799 branch October 8, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protection Key is not removed during tenant removal
3 participants