Microsoft.AspNetCore.Mvc.JsonOptions uses default instead of OC JOptions settings

[wAsnk]

Describe the bug

Only Microsoft.AspNetCore.Http.Json.JsonOptions is configured here with the OC Json settings, while Microsoft.AspNetCore.Mvc.JsonOptions is kept as default, causing not minimal Apis using the default Microsoft.AspNetCore.Mvc.JsonOptions during model binding deserialization.

Expected behavior

Both JsonOptions should use the same settings, a similar configuration merge should be done for Microsoft.AspNetCore.Mvc.JsonOptions to ensure same behavior.

[hishamco]

@wAsnk feel free to submit a PR

[wAsnk]

@wAsnk feel free to submit a PR

If I'll have spare time I'll do it and if someone else won't do it in the meantime.

[hishamco]

I will submit a PR tonight

[MikeAlhayek]

I am not sure it is the best idea to change the global JsonOptions for OC project as it could impact users negatively.

In the minimal API where you are returning content item, I would just return the result differently.

For example, https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Contents/Endpoints/Api/GetEndpoint.cs#L45

instead of returning return TypedResults.Ok(contentItem);, we can return Results.Json(contentItem, options.Value.SerializerOptions); while IOptions<DocumentJsonSerializerOptions> options would be injected into the HandleAsync method.

Same goes to here: https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Contents/Endpoints/Api/DeleteEndpoint.cs#L47

and

https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Contents/Endpoints/Api/CreateEndpoint.cs#L126

Also, the JsonOptionsConfigurations should be removed so we don't expose global app settings that would override .NET core framework by default. @sebastienros thoughts?

[MikeAlhayek]

@wAsnk can you please share with us a content item that caused an exception in the minimalApi?

It would be great if you have a repo to ensure it is properly fixed.

[wAsnk]

@MikeAlhayek
Sorry it might've been misunderstandable. I was experiencing this with NOT minimal APIs, so with ApiControllers. In ApiControllers, SystemTextJsonInputFormatter and SystemTextJsonOutputFormatter is used during model binding, and the serializer there uses settings from Microsoft.AspNetCore.Mvc.JsonOptions.

I think setting globally the JsonOptions should be either for both or neither. But neither looks like the better solution.

Btw this wasn't my root problem, it was just a sidequest for me apparently.... My original problem was that I had a Collection with a private setter in a generated class, so while the OC defined settings where the JsonObjectCreationHandling was set to Populate the collection was populated. But with the default settings of JsonOptions the JsonObjectCreationHandling is set to Replace, thus a private setter won't allow the collection to be set. So during deserialization I was missing data.
While I didn't know the exact problem I just copied the Http.JsonOptions to the Mvc.JsonOptions and used that everywhere.
My final solution now is that I removed the Http.JsonOptions like you did in your PR. And also now I generate the class with a public setter for the collection. Now I can serialize-deserialize back and forth with the same result, unlike before.

[MikeAlhayek]

Thanks @wAsnk I also added a default output formatter to provide a way to deserialize Document and Entity by default.

[Piedone]

Fixed by #16837.