Don't configure JsonOptions by default

[MikeAlhayek]

Fix #16831

[hishamco]

I have two notes about this:

1. It introducing a breaking-change
2. Why we have it before?

[MikeAlhayek]

It introducing a breaking-change

I would say this is a bug in 2.0 and should be fixed. If someone already build on the top of the bug, we should fix the bug and release it. We should document it as a breaking change due to a bug.

Why we have it before?

Not sure but I added it in #15460

[hishamco]

I would say this is a bug in 2.0 and should be fixed

I suggest deprecating the type with an error when someone uses it, please no more breaking changes as we follow SemVer

[MikeAlhayek]

the type in already internal so it won't break anyone. It is would break their behavior if they are using API or endpoint on 2.0 that returns ContentItem. Again, this is a bug in 2.0 and should be addressed as a bug.

[hishamco]

You're right I though it's a public type

[Piedone]

I don't think this is a breaking change, but still deserves a note in the release notes. I don't understand though how #15460 fixed originally, since it wasn't about web APIs.

[Piedone]

How did #15460 fix its issue originally (since it wasn't about web APIs), and how does this not break what it fixed?

[Piedone]

So, how did #15460 fix its issue originally (since it wasn't about web APIs), and how does this not break what it fixed?

[MikeAlhayek]

So, how did #15460 fix its issue originally (since it wasn't about web APIs), and how does this not break what it fixed?

I don't think it fixed anything. Look at the comment here #15416 (comment) it sound as he just used a different options.

[Piedone]

Ah I see.

[Piedone]

I tested the APIs with https://github.com/Lombiq/Orchard-Core-API-Client and didn't notice any issues.