Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform button shape names for Admin #5126

Closed
ns8482e opened this issue Dec 25, 2019 · 3 comments
Closed

Uniform button shape names for Admin #5126

ns8482e opened this issue Dec 25, 2019 · 3 comments
Milestone

Comments

@ns8482e
Copy link
Contributor

ns8482e commented Dec 25, 2019

For Admin, Different button shapes are used, It would be nice to have standard naming convention for all these button shapes, so that developer can create predictable alternates for Admin Theme.

e.g.

  • ContentPreview_Button
  • Content_PublishButton
  • Content_SaveDraftButton

For example, I would like to show "Actions" zone as drop-down similar to #3688 (comment) and overriding above shapes with alternates. As following

Content-Dropdown.PublishButton.cshtml ( Content_PublishButton__Dropdown)
Content-Dropdown.SaveDraftButton.cshtml (Content_SaveDraftButton__Dropdown)

However for preview naming is different than above,

ContentPreview-Dropdown.Button.cshtml ( ContentPreview_Button__Dropdown )

Notice the position of - in filenames above, its confusing.

I suggest to have all button shape uniform naming.

@ns8482e ns8482e changed the title Uniform button shape name Uniform button shape names for Admin Dec 25, 2019
@sebastienros sebastienros added this to the backlog milestone Dec 26, 2019
@agriffard
Copy link
Member

Can you provide a PR?

@ns8482e
Copy link
Contributor Author

ns8482e commented Sep 17, 2020

Fix in PR #7086 is also related, due to not having uniform naming and shape type contains __ and _
The original shape type should not contain __ or _

I could wok on PR to change shape type to not contain _ or __.
Also note that here prefix Content is not used to represent stereotype of the content item

So change would be as as following,

ContentPreview_Button --> ContentPreviewButton
Content_PublishButton --> ContentPublishButton
Content_SaveDraftButton --> ContentSaveDraftButton

@agriffard
Copy link
Member

Can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants