Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape type naming convention #5151

Closed
sebastienros opened this issue Dec 28, 2019 · 6 comments
Closed

Shape type naming convention #5151

sebastienros opened this issue Dec 28, 2019 · 6 comments

Comments

@sebastienros
Copy link
Member

[Stereotype]_[DisplayType]__[Subject]
Each element should not contain __ or _.

Example: Content_SummaryAdmin__ActionButtons instead of Content_SummaryAdmin__Button__Actions

For editor/display modes, we should use explicit driver registrations, which will drive the shapes to edit/display following the same rule.

@ns8482e
Copy link
Contributor

ns8482e commented Dec 28, 2019

Related #5126

Also, All Parts in Form Modules, e.g ButtonPart_Fields_Edit should be ButtonPart_Edit

@sebastienros sebastienros added this to the backlog milestone Jan 2, 2020
@sebastienros
Copy link
Member Author

Might not be necessary anymore as JT found a solution to the issue that triggered this suggestion.

But the editor/display mode part is still valid.

@deanmarcussen
Copy link
Member

possible fix for the editor/display explicit registration on #4361

@Piedone
Copy link
Member

Piedone commented May 3, 2024

Is there anything still necessary here?

Copy link
Contributor

It seems that this issue didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please reply.

@github-actions github-actions bot added the stale label May 25, 2024
Copy link
Contributor

github-actions bot commented Jun 2, 2024

Closing this issue because it has been stale for very long. If you think this is still relevant, feel free to reopen it.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants