Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jquery CDN load failed #7721

Closed
JohnnyZhang0628 opened this issue Nov 23, 2020 · 12 comments
Closed

Jquery CDN load failed #7721

JohnnyZhang0628 opened this issue Nov 23, 2020 · 12 comments
Milestone

Comments

@JohnnyZhang0628
Copy link

I 'm .net developer from china. Due to network , CDN scripts can't load success.Please add a picker in SetUpPage.Thanks

@Skrypt
Copy link
Contributor

Skrypt commented Nov 23, 2020

See
#7599
#7707

@JohnnyZhang0628
Copy link
Author

@Skrypt Thanks reply. Besides using hishamco/use-cdn branch ,are there other ways?The dev branch will consider to add the function?

@Skrypt
Copy link
Contributor

Skrypt commented Nov 23, 2020

We will discuss about it this week with @sebastienros
I will try to take some time tomorrow to test the PR and see if everything could work with it.
Yes, it will eventually be merged in the dev branch.
The issue we have with a CDN setting on the setup is that now we need to define if it should be enabled or not by default. Also, it feels like this option should be configurable from the appsettings.json file.
Also, enabling the CDN doesn't garantee that the CDN will work so we should do some DNS tests first before enabling it. Else it makes the admin UI totally unusable. So there is more work than what it seems to be.

@JohnnyZhang0628
Copy link
Author

@Skrypt Thanks Reply.I looking foward to next version ASAP.

@deanmarcussen
Copy link
Member

Reopening this as for all the complaints about it, we have no issue tracking it.

workarounds

add this to your startup project.

using Microsoft.Extensions.Options;
using OrchardCore.ResourceManagement;

namespace OrchardCore.Cms.Web
{
    public class Startup
    {
        public void ConfigureServices(IServiceCollection services)
        {
            services.AddOrchardCms()
                .ConfigureServices(tenantServices => {
                    tenantServices.PostConfigure<ResourceManagementOptions>(o => o.UseCdn = false);
                });
        }

or after setup, navigate to
https://localhost:5001/Admin/Settings/general and disable the 'Use Framework CDN'`

@JohnnyZhang0628
Copy link
Author

@deanmarcussen Thanks.The problem has solved 😃.
image

@sebastienros sebastienros modified the milestones: 1.0.x, 1.0 Dec 10, 2020
@agriffard
Copy link
Member

Can this be closed: It seems it has been solved.

@sebastienros
Copy link
Member

Needs documentation

@Skrypt
Copy link
Contributor

Skrypt commented Dec 29, 2020

This issue should be taken care in first priority for 1.0
@hishamco is working on a PR #7599
But there is also documentation to write about the possible workarounds.

@agriffard
Copy link
Member

The Resource settings are in the second tab in General and if jQuery is not loaded, you cannot switch to change the CDN options.

@agriffard
Copy link
Member

See also #8154

@sebastienros
Copy link
Member

#8324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants