Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin filters in contents list dont work nicely with placement #8020

Closed
giannik opened this issue Dec 16, 2020 · 3 comments · Fixed by #8089
Closed

Admin filters in contents list dont work nicely with placement #8020

giannik opened this issue Dec 16, 2020 · 3 comments · Fixed by #8089

Comments

@giannik
Copy link
Contributor

giannik commented Dec 16, 2020

When in the admin in the contents list I would like to reposition the admin filters using placement files :

So there seems to be the following shapes used in the filters display :
ContentsAdminList
-ContentsAdminList__Search
-ContentsAdminList__Create
-ContentsAdminList__Summary
-ContentsAdminList__Filters

which give out the following layout :

image

In the admintheme if i add a placement.json file with following rule :

{
  "ContentsAdminList__Search": [
    {
      "place": "-"
    }
  ] 
}

Then i get the following output , all the filter shapes have dissapeared

image

Not what i hoped for. Was expecting only the text search element to be hidden.
Is this a bug ?
Ideally i would like to reposition thse filter shapes in a sidebar zone using some placement syntax like this :

{
  "ContentsAdminList__Search": [
    {
      "place": "\Sidebar:1"
    }
  ] ,
  "ContentsAdminList__Filters": [
    {
      "place": "\Sidebar:2"
    }
  ]

}

@deanmarcussen

By the way, thanks for this great feature, especially the taxonomies integration is terrific.

@deanmarcussen
Copy link
Member

@giannik it's going to be the same issue as was fixed here #7086

Suggest the shape names would need to be renamed to ContentsAdminListSearch to work with placement

@Skrypt
Copy link
Contributor

Skrypt commented Dec 17, 2020

Please take a note that these search forms have small differences for when they use a filter or not.
We are still defining Admin UI elements this is mainly why I did not use a shape for now.
If you want to have a common shape for all lists this might take some params to differenciate some elements.

search for : has-filter and has-search styles for example

@deanmarcussen
Copy link
Member

Different issue @Skrypt this is about the shape names for the extended filters for the CI list - taxonomies / culture etc.

So not the form, just some shapes that make up the elements

This was referenced Dec 19, 2020
agriffard pushed a commit that referenced this issue Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants