Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide IConfiguration extensions to configure certain modules (Lombiq Technologies: OCORE-97) #12033

Merged
merged 12 commits into from
Sep 7, 2022
Merged

Provide IConfiguration extensions to configure certain modules (Lombiq Technologies: OCORE-97) #12033

merged 12 commits into from
Sep 7, 2022

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Jul 18, 2022 •
edited
Loading

Addresses #6036

@hishamco hishamco requested a review from Piedone July 18, 2022 23:20
@hishamco hishamco requested a review from agriffard as a code owner July 18, 2022 23:20
@hishamco hishamco removed the request for review from agriffard July 18, 2022 23:21
@hishamco
Copy link
Member Author

@Piedone shall we add sample configuration for each in appsettings like other modules or docs are enough in this case?

Piedone
Piedone requested changes Jul 19, 2022
View reviewed changes
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, samples would be useful too.

src/OrchardCore.Modules/OrchardCore.GitHub/Extensions/OrchardCoreBuilderExtensions.cs Show resolved Hide resolved
src/docs/reference/modules/Email/README.md Outdated Show resolved Hide resolved
src/OrchardCore.Modules/OrchardCore.Email/Extensions/OrchardCoreBuilderExtensions.cs Show resolved Hide resolved
@Piedone
Copy link
Member

Piedone commented Jul 21, 2022

Having the same for OrchardCore.Microsoft.Authentication would be useful too.

@hishamco
Copy link
Member Author

I'm just testsing bind non primitive data types from appsettings, then I can add OrchardCore.Microsoft.Authentication

@hishamco
Copy link
Member Author

PathString not binded by default, so I'm trying to find a simple way to make it works instead of using string as datatype for CallbackPath

@hishamco
Copy link
Member Author

It works fine, just forgot that it should start with /

@hishamco hishamco requested a review from Piedone July 25, 2022 18:27
@hishamco
Copy link
Member Author

Anything else we need to add here?

@hishamco
Copy link
Member Author

hishamco commented Sep 6, 2022

@Piedone did we miss anything else here?

@Piedone
Copy link
Member

Piedone commented Sep 6, 2022

I don't understand the question.

@hishamco
Copy link
Member Author

hishamco commented Sep 6, 2022

What I mean is there anything else to finish this PR?

@Piedone
Copy link
Member

Piedone commented Sep 6, 2022

As usual, if you are done addressing PR feedback, use the re-request review feature.

@hishamco hishamco merged commit bd2fe3a into main Sep 7, 2022
@hishamco hishamco deleted the hishamco/configuration-extensions branch September 7, 2022 07:05
@hishamco hishamco mentioned this pull request Sep 11, 2022
Closed
@Piedone Piedone mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piedone Piedone Piedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hishamco @Piedone