New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Prototype] Update the OpenID module to use the OpenIddict client #14021

Draft

kevinchalet wants to merge 1 commit into OrchardCMS:main from kevinchalet:openiddict_client

Member

kevinchalet commented Jul 21, 2023 •

edited by Piedone

Loading

This is a very crude PR that replaces the MSFT OIDC handler in OrchardCore.OpenId by the OpenIddict client. I deliberately didn't touch the OpenID client recipe to avoid a source/binary breaking change and used multiple mappings to avoid behavior changes.

Open questions:

Do we want to support configuring multiple client registrations (to connect with multiple OpenID Connect servers)? It's not something currently supported by the OpenID client feature and would likely require changes to the UI/recipes.
Do we want to use OpenIddict's web providers? If so, how do we architecture things? Do we want to merge the Facebook/Google/GitHub/Entra ID/Twitter modules into OrchardCore.OpenId?

Related discussion: OrchardCoreContrib/OrchardCoreContrib.Modules#90.

Depends on #7891.

/cc @hishamco @MichaelPetrinolis

kevinchalet added OpenId discussion don't merge labels

kevinchalet added this to the backlog milestone

kevinchalet self-assigned this

kevinchalet force-pushed the openiddict_client branch from 03addeb to 22dacf6 Compare

July 21, 2023 14:02

kevinchalet mentioned this pull request

OpenId Module based on OpenIddict Client OrchardCoreContrib/OrchardCoreContrib.Modules#90

Open

kevinchalet commented

View reviewed changes

src/OrchardCore.Build/Dependencies.props Outdated Show resolved Hide resolved

kevinchalet commented

View reviewed changes

NuGet.config Outdated Show resolved Hide resolved

kevinchalet force-pushed the openiddict_client branch from 7196e60 to 74c7d43 Compare

September 12, 2023 18:22

kevinchalet mentioned this pull request

Update OpenIddict 4.8.0 #14321

Merged

kevinchalet force-pushed the openiddict_client branch from 74c7d43 to e832b7f Compare

January 18, 2024 16:30

Member

Piedone commented Jan 18, 2024

So this depends on #7891, right?

Member Author

kevinchalet commented Jan 18, 2024

So this depends on #7891, right?

Technically, we could use the same X.509 certificates generation logic as the server feature but since it's something we want to get rid of once the secrets module is ready, it's likely better to just wait so yeah 😃

Member

Piedone commented Jan 18, 2024

OK then, thank you. I think it's better as a draft, then, for now.

Piedone mentioned this pull request

Secrets module (Lombiq Technologies: OCORE-124) #7891

Closed

github-actions bot added the merge conflict label

Contributor

github-actions bot commented Feb 8, 2024

This pull request has merge conflicts. Please resolve those before requesting a review.

Piedone marked this pull request as draft

April 21, 2024 19:13

kevinchalet mentioned this pull request

Unable to read non-standard claims from OpenID IdP #15808

Closed

Piedone removed the discussion label

kevinchalet force-pushed the openiddict_client branch from e832b7f to 206fa94 Compare

May 22, 2024 15:08

github-actions bot removed the merge conflict label

kevinchalet force-pushed the openiddict_client branch from 206fa94 to 1ea1213 Compare

May 22, 2024 15:31

github-actions bot added the merge conflict label

Contributor

github-actions bot commented May 24, 2024

This pull request has merge conflicts. Please resolve those before requesting a review.

Contributor

github-actions bot commented Jul 23, 2024

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

github-actions bot added the stale label

kevinchalet force-pushed the openiddict_client branch from 1ea1213 to 4a1b7a5 Compare

July 23, 2024 17:02

github-actions bot removed the merge conflict label

kevinchalet removed the stale label

Member Author

kevinchalet commented Jul 23, 2024

Rebased on top of main.

Contributor

github-actions bot commented Aug 14, 2024

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions bot added the merge conflict label

kevinchalet force-pushed the openiddict_client branch from 4a1b7a5 to 3b00f87 Compare

August 14, 2024 13:49

github-actions bot added merge conflict and removed merge conflict labels

Contributor

github-actions bot commented Aug 16, 2024

This pull request has merge conflicts. Please resolve those before requesting a review.


          [Prototype] Update the OpenID module to use the OpenIddict client

46462d1

kevinchalet force-pushed the openiddict_client branch from 3b00f87 to 46462d1 Compare

August 17, 2024 05:23

github-actions bot removed the merge conflict label

github-actions bot added the merge conflict label

Contributor

github-actions bot commented Sep 16, 2024

This pull request has merge conflicts. Please resolve those before requesting a review.

Contributor

github-actions bot commented Nov 16, 2024

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

github-actions bot added the stale label

kevinchalet removed the stale label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

don't merge merge conflict OpenId