Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim Async suffix #14407

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Trim Async suffix #14407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultShapeFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public override bool TryInvokeMember(InvokeMemberBinder binder, object[] args, o

if (binderName.EndsWith("Async", StringComparison.Ordinal))
{
binderName = binder.Name[^"Async".Length..];
binderName = binder.Name[..^"Async".Length];
}

result = ShapeFactoryExtensions
Expand Down
9 changes: 9 additions & 0 deletions test/OrchardCore.Tests/DisplayManagement/ShapeFactoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,15 @@ public async Task CallSyntax()
Assert.Equal("Foo", metadata.Type);
}

[Fact]
public async Task CallSyntaxAsync()
{
dynamic factory = _serviceProvider.GetService<IShapeFactory>();
var foo = await factory.FooAsync();
ShapeMetadata metadata = foo.Metadata;
Assert.Equal("Foo", metadata.Type);
}

[Fact]
public async Task CallInitializer()
{
Expand Down