Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Cannot update your own roles" warning #14440

Merged
merged 1 commit into from
Oct 9, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -96,17 +96,15 @@ public override IDisplayResult Edit(User user)

public override async Task<IDisplayResult> UpdateAsync(User user, UpdateEditorContext context)
{
var model = new EditUserRoleViewModel();

// The current user cannot alter their own roles. This prevents them removing access to the site for themselves.
if (_httpContextAccessor.HttpContext.User.FindFirstValue(ClaimTypes.NameIdentifier) == user.UserId
&& !await _authorizationService.AuthorizeAsync(_httpContextAccessor.HttpContext.User, StandardPermissions.SiteOwner))
{
await _notifier.WarningAsync(H["Cannot update your own roles."]);

return Edit(user);
return null;
}

var model = new EditUserRoleViewModel();

if (await context.Updater.TryUpdateModelAsync(model, Prefix))
{
var roles = await GetRoleAsync();
Expand Down